Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

fix outbound connection check for master VMSS#44

Merged
CecileRobertMichon merged 1 commit intoAzure:masterfrom
CecileRobertMichon:fix-nc-cmd
Nov 20, 2018
Merged

fix outbound connection check for master VMSS#44
CecileRobertMichon merged 1 commit intoAzure:masterfrom
CecileRobertMichon:fix-nc-cmd

Conversation

@CecileRobertMichon
Copy link
Contributor

What this PR does / why we need it: Fix typo in master VMSS command causing failing outbound check.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@CecileRobertMichon CecileRobertMichon added the bug Something isn't working label Nov 20, 2018
@tariq1890
Copy link
Contributor

/lgtm

@codecov
Copy link

codecov bot commented Nov 20, 2018

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   52.41%   52.41%           
=======================================
  Files          91       91           
  Lines       12792    12792           
=======================================
  Hits         6705     6705           
  Misses       5479     5479           
  Partials      608      608

@mboersma
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Nov 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, mboersma, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,mboersma,tariq1890]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CecileRobertMichon CecileRobertMichon merged commit 1071ce1 into Azure:master Nov 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved bug Something isn't working lgtm size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants