Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

WIP: feat: upgrade to Windows Containerd config to v2 and enable hostprocess annotations#4472

Closed
jsturtevant wants to merge 1 commit intoAzure:masterfrom
jsturtevant:hostprocess-updates
Closed

WIP: feat: upgrade to Windows Containerd config to v2 and enable hostprocess annotations#4472
jsturtevant wants to merge 1 commit intoAzure:masterfrom
jsturtevant:hostprocess-updates

Conversation

@jsturtevant
Copy link
Copy Markdown
Contributor

Reason for Change:

Enables alpha host process feature in Containerd.

Currently, To use hostprocess you need k8s 1.22.0-alpha.2+ and the following flags:

          "kubeletConfig": {
              "-v": "5",
              "--feature-gates": "WindowsHostProcessContainers=true"
          },
          "apiServerConfig": {
            "--feature-gates": "WindowsHostProcessContainers=true"
          },

Also need the containerd-shim binary built from microsoft/hcsshim#962

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot
Copy link
Copy Markdown

acs-bot commented Jun 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@3b6306d). Click here to learn what that means.
The diff coverage is 38.28%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4472   +/-   ##
=========================================
  Coverage          ?   72.05%           
=========================================
  Files             ?      141           
  Lines             ?    21765           
  Branches          ?        0           
=========================================
  Hits              ?    15682           
  Misses            ?     5131           
  Partials          ?      952           
Impacted Files Coverage Δ
cmd/rotatecerts/arm.go 0.00% <0.00%> (ø)
cmd/rotate_certs.go 11.03% <11.03%> (ø)
cmd/scale.go 12.56% <12.37%> (ø)
cmd/addpool.go 17.97% <17.97%> (ø)
cmd/update.go 23.07% <23.07%> (ø)
cmd/upgrade.go 35.92% <25.00%> (ø)
cmd/get_logs.go 49.57% <49.57%> (ø)
cmd/get_skus.go 50.63% <50.63%> (ø)
cmd/root.go 56.28% <52.63%> (ø)
cmd/generate.go 50.41% <54.54%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b6306d...709e766. Read the comment docs.

@jsturtevant
Copy link
Copy Markdown
Contributor Author

We are now using containerd 1.6 in our tests which no longer needs this
/close

@jsturtevant jsturtevant closed this Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants