Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

Add docker-engine feature flag for docker-engine w/ Ubuntu distro#47

Merged
jackfrancis merged 5 commits intoAzure:masterfrom
CecileRobertMichon:docker-engine-ubuntu
Nov 21, 2018
Merged

Add docker-engine feature flag for docker-engine w/ Ubuntu distro#47
jackfrancis merged 5 commits intoAzure:masterfrom
CecileRobertMichon:docker-engine-ubuntu

Conversation

@CecileRobertMichon
Copy link
Contributor

What this PR does / why we need it: Deployments w/ GPU nodes in sovereign clouds need to install docker-engine without VHD as Moby is not compatible w/ GPU and AKS VHD is not yet available in sovereign clouds.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Nov 21, 2018
@codecov
Copy link

codecov bot commented Nov 21, 2018

Codecov Report

Merging #47 into master will increase coverage by 0.03%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   52.41%   52.44%   +0.03%     
==========================================
  Files          91       91              
  Lines       12792    12801       +9     
==========================================
+ Hits         6705     6714       +9     
- Misses       5479     5481       +2     
+ Partials      608      606       -2

@jackfrancis
Copy link
Member

/lgtm

@jackfrancis jackfrancis merged commit 9fa1c23 into Azure:master Nov 21, 2018
@acs-bot
Copy link

acs-bot commented Nov 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants