This repository was archived by the owner on Oct 24, 2023. It is now read-only.
Add docker-engine feature flag for docker-engine w/ Ubuntu distro#47
Merged
jackfrancis merged 5 commits intoAzure:masterfrom Nov 21, 2018
CecileRobertMichon:docker-engine-ubuntu
Merged
Add docker-engine feature flag for docker-engine w/ Ubuntu distro#47jackfrancis merged 5 commits intoAzure:masterfrom CecileRobertMichon:docker-engine-ubuntu
jackfrancis merged 5 commits intoAzure:masterfrom
CecileRobertMichon:docker-engine-ubuntu
Conversation
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 52.41% 52.44% +0.03%
==========================================
Files 91 91
Lines 12792 12801 +9
==========================================
+ Hits 6705 6714 +9
- Misses 5479 5481 +2
+ Partials 608 606 -2 |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Deployments w/ GPU nodes in sovereign clouds need to install docker-engine without VHD as Moby is not compatible w/ GPU and AKS VHD is not yet available in sovereign clouds.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: