This repository was archived by the owner on Oct 24, 2023. It is now read-only.
Replace docker engine feature flag by existing cloud spec#51
Merged
jackfrancis merged 2 commits intoAzure:masterfrom Nov 21, 2018
Merged
Replace docker engine feature flag by existing cloud spec#51jackfrancis merged 2 commits intoAzure:masterfrom
jackfrancis merged 2 commits intoAzure:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
- Coverage 52.44% 52.44% -0.01%
==========================================
Files 91 91
Lines 12801 12801
==========================================
- Hits 6714 6713 -1
+ Misses 5481 5480 -1
- Partials 606 608 +2 |
| installContainerRuntime | ||
| installNetworkPlugin | ||
| installContainerd | ||
| if [[ "${GPU_NODE}" = true ]]; then |
Contributor
There was a problem hiding this comment.
we'll need to backport this fix to acs-engine
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
Manually validated N series + ubuntu distro |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Remove the need for a feature flag to get docker-engine w/ GPU nodes in a non-VHD scenario. Instead, simply pass in a docker-engine repo URL when GPU nodes are present.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: