This repository was archived by the owner on Oct 24, 2023. It is now read-only.
revert: commit generated code files#546
Merged
jackfrancis merged 1 commit intoAzure:masterfrom Feb 21, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
=========================================
- Coverage 54.75% 54.7% -0.06%
=========================================
Files 97 97
Lines 14708 14696 -12
=========================================
- Hits 8054 8039 -15
- Misses 5980 5981 +1
- Partials 674 676 +2 |
Member
Author
|
I'm going to update this to leave the |
mboersma
force-pushed
the
revert-commit-generated
branch
from
bf59d34 to
4153274
Compare
mboersma
force-pushed
the
revert-commit-generated
branch
from
4153274 to
cfe7067
Compare
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Feb 21, 2019
sylr
pushed a commit
to sylr/aks-engine
that referenced
this pull request
Feb 28, 2019
juhacket
pushed a commit
to juhacket/aks-engine
that referenced
this pull request
Mar 14, 2019
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The change in #449 really didn't work out--there has been constant contention over templates_generated.go which requires every PR to be rebased.
Issue Fixed:
Requirements:
Notes:
Let's revisit the idea of aks-engine being purely
go get-table soon. For now we don't want the confusion + churn that comes with committing the generated files.