Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

Fix issue caused by updating azure.json#65

Merged
jackfrancis merged 1 commit intoAzure:masterfrom
jackfrancis:kms-fix
Nov 27, 2018
Merged

Fix issue caused by updating azure.json#65
jackfrancis merged 1 commit intoAzure:masterfrom
jackfrancis:kms-fix

Conversation

@jackfrancis
Copy link
Member

What this PR does / why we need it: Fix issue caused by updating azure.json
Details for the fix: Azure/kubernetes-kms#37

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #49

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

Fix issue caused by updating azure.json

@tariq1890
Copy link
Contributor

@ritazh FYI

@ritazh
Copy link
Member

ritazh commented Nov 27, 2018

/lgtm

@acs-bot
Copy link

acs-bot commented Nov 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 27, 2018

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   52.44%   52.44%           
=======================================
  Files          91       91           
  Lines       12801    12801           
=======================================
  Hits         6713     6713           
  Misses       5480     5480           
  Partials      608      608

@jackfrancis jackfrancis merged commit 9d34b86 into Azure:master Nov 27, 2018
@jackfrancis jackfrancis deleted the kms-fix branch November 27, 2018 01:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KMS encryption produces zero byte azure.json

4 participants