Skip to content

Comments

feat(core): bump tsp 0.51.0 and cadl-ranch 0.28.0#4022

Merged
pshao25 merged 14 commits intoAzure:feature/v3from
archerzz:typespec/0.51.0
Dec 19, 2023
Merged

feat(core): bump tsp 0.51.0 and cadl-ranch 0.28.0#4022
pshao25 merged 14 commits intoAzure:feature/v3from
archerzz:typespec/0.51.0

Conversation

@archerzz
Copy link
Member

@archerzz archerzz commented Dec 8, 2023

Description

  • bump typespec 0.51.0 and depending libraries
  • bump cadl-ranch 0.28.0
  • recursively load multiple-level client hierarchy
  • regen tests/samples
  • fix some tests

resolve #4021

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@archerzz
feat(core): bump tsp 0.51.0 and cadl-ranch 0.28.0
c43fa88 
- bump typespec 0.51.0 and depending libraries
- bump cadl-ranch 0.28.0
- recursively load multiple-level client hierarchy
- regen tests/samples
- fix some tests

resolve Azure#4021
@archerzz
Copy link
Member Author

archerzz commented Dec 8, 2023 •
edited
Loading

blocked by #4023

@archerzz archerzz added the DPG label Dec 8, 2023
This was referenced Dec 8, 2023
Closed
Closed
@azure-sdk azure-sdk mentioned this pull request Dec 11, 2023
Closed
@archerzz
Copy link
Member Author

archerzz commented Dec 12, 2023

blocked by #4019

@archerzz
Merge branch 'feature/v3' into typespec/0.51.0
a7d8129 
# Conflicts:
#	test/TestProjects/FirstTest-TypeSpec/src/Generated/Docs/FirstTestTypeSpecClient.xml
#	test/TestProjects/FirstTest-TypeSpec/src/Generated/FirstTestTypeSpecClient.cs
#	test/TestProjects/FirstTest-TypeSpec/src/Generated/tspCodeModel.json
#	test/TestProjects/FirstTest-TypeSpec/tests/Generated/Samples/Samples_FirstTestTypeSpecClient.cs
@archerzz
fix test format
2406bad
@archerzz archerzz mentioned this pull request Dec 13, 2023
Closed
@azure-sdk azure-sdk mentioned this pull request Dec 13, 2023
Closed
@archerzz
ignore delete operation result
2d9a0e7
@archerzz
Merge branch 'feature/v3' into typespec/0.51.0
c5b1864 
# Conflicts:
#	test/CadlRanchProjects/azure/core/lro/rpc-legacy/src/Generated/Docs/LegacyClient.xml
#	test/CadlRanchProjects/azure/core/lro/rpc-legacy/src/Generated/LegacyClient.cs
#	test/CadlRanchProjects/azure/core/lro/rpc-legacy/src/Generated/tspCodeModel.json
#	test/CadlRanchProjects/azure/core/lro/rpc-legacy/tests/Generated/Samples/Samples_LegacyClient.cs
#	test/TestProjects/FirstTest-TypeSpec/src/Generated/Docs/FirstTestTypeSpecClient.xml
#	test/TestProjects/FirstTest-TypeSpec/src/Generated/FirstTestTypeSpecClient.cs
#	test/TestProjects/FirstTest-TypeSpec/src/Generated/tspCodeModel.json
#	test/TestProjects/FirstTest-TypeSpec/tests/Generated/Samples/Samples_FirstTestTypeSpecClient.cs
#	test/TestProjects/PetStore-TypeSpec/src/Generated/PetStoreClient.cs
#	test/TestProjects/PetStore-TypeSpec/src/Generated/tspCodeModel.json
@azure-sdk azure-sdk mentioned this pull request Dec 14, 2023
Merged
@archerzz
Copy link
Member Author

archerzz commented Dec 14, 2023

We're close to merging this PR. From the latest preview PR:

  • breaking change in AnomalyDetector is expected due to client hierarchy feature, and that SDK is deprecated
  • breaking change in healthinsights should be fixed in upstream typespec fix: fix(healthinsights): add @lroResult azure-rest-api-specs#27081
  • devcenter is fixed by restoring the logic of excluding return value for delete method

@azure-sdk azure-sdk mentioned this pull request Dec 18, 2023
Closed
lirenhe
lirenhe reviewed Dec 18, 2023
View reviewed changes
@pshao25 pshao25 merged commit a777802 into Azure:feature/v3 Dec 19, 2023
@archerzz archerzz mentioned this pull request Dec 25, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pshao25 pshao25 pshao25 left review comments

@lirenhe lirenhe lirenhe approved these changes

@m-nash m-nash Awaiting requested review from m-nash

@jsquire jsquire Awaiting requested review from jsquire

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978

@hallipr hallipr Awaiting requested review from hallipr

@christothes christothes Awaiting requested review from christothes

Assignees

No one assigned

Labels

DPG

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bump typespec 0.51.0 and cadl-ranch 0.28.0

3 participants

@archerzz @lirenhe @pshao25