Bring back Utf8JsonRequestContent/Utf8JsonBinaryContent and RequestContentHelper/BinaryContentHelper for non-azure libraries#4573
Merged
ArcturusZhang merged 30 commits intoAzure:feature/v3from Apr 23, 2024
Conversation
RequestContentHelper and Utf8JsonRequestContent back for non-azure librariesUtf8JsonRequestContent and bring it back for non-azure libraries
63ac61b to
5c52051
Compare
Utf8JsonRequestContent and bring it back for non-azure librariesUtf8JsonRequestContent/Utf8JsonBinaryContent and RequestContentHelper/BinaryContentHelper for non-azure libraries
76bcab8 to
935e398
Compare
annelo-msft
reviewed
Apr 15, 2024
test/UnbrandedProjects/Unbranded-TypeSpec/src/Generated/UnbrandedTypeSpecClient.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Apr 15, 2024
test/UnbrandedProjects/Unbranded-TypeSpec/src/Generated/Internal/BinaryContentHelper.cs
Show resolved
Hide resolved
6 tasks
chunyu3
approved these changes
Apr 19, 2024
lirenhe
approved these changes
Apr 19, 2024
This was referenced Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4571
Description
The current implementation of
Utf8JsonRequestContentis using aStreamRequestContentinside it for its content, we only have aBinaryContent.Createmethod in SCM that consumes aStreamin version1.1.0-beta.3, this PR updates the version and use it.Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?