Skip to content

Comments

Bring back Utf8JsonRequestContent/Utf8JsonBinaryContent and RequestContentHelper/BinaryContentHelper for non-azure libraries#4573

Merged
ArcturusZhang merged 30 commits intoAzure:feature/v3from
ArcturusZhang:introduce-helpers-back
Apr 23, 2024
Merged

Bring back Utf8JsonRequestContent/Utf8JsonBinaryContent and RequestContentHelper/BinaryContentHelper for non-azure libraries#4573
ArcturusZhang merged 30 commits intoAzure:feature/v3from
ArcturusZhang:introduce-helpers-back

Conversation

@ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Apr 12, 2024

Fixes #4571

Description

The current implementation of Utf8JsonRequestContent is using a StreamRequestContent inside it for its content, we only have a BinaryContent.Create method in SCM that consumes a Stream in version 1.1.0-beta.3, this PR updates the version and use it.

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@ArcturusZhang ArcturusZhang changed the title Introduce the RequestContentHelper and Utf8JsonRequestContent back for non-azure libraries Refine implementation of Utf8JsonRequestContent and bring it back for non-azure libraries Apr 12, 2024
@ArcturusZhang ArcturusZhang force-pushed the introduce-helpers-back branch from 63ac61b to 5c52051 Compare April 15, 2024 02:07
@ArcturusZhang ArcturusZhang changed the title Refine implementation of Utf8JsonRequestContent and bring it back for non-azure libraries Bring back Utf8JsonRequestContent/Utf8JsonBinaryContent and RequestContentHelper/BinaryContentHelper for non-azure libraries Apr 15, 2024
@ArcturusZhang ArcturusZhang marked this pull request as ready for review April 15, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ClientModel-based clients] Introduce back RequestContentHelper and Utf8JsonRequestContent

4 participants