Merged
Conversation
|
@olydis, |
changlong-liu
pushed a commit
to changlong-liu/autorest.csharp
that referenced
this pull request
Nov 4, 2021
1. cache generated method names when parsing code model 2. catch duplicated method names and show error message with prompt 3. refactor `Resource` to extract a static method which can build the `operation_id` from `OperationGroup` and `Operation`. Azure#1626
changlong-liu
pushed a commit
to changlong-liu/autorest.csharp
that referenced
this pull request
Nov 4, 2021
This reverts commit c815520.
ArthurMa1978
pushed a commit
that referenced
this pull request
Nov 16, 2021
* initial commit * update * some update * update * revert a useless method * implemented resource detection * some more implementation and refinement * added some functionality to adopt current implementation of operation groups * some more effort to make sure our current implementation works * some fundamental change to encapsulate operation group * clean up code * remove direct reference of operation group from resource data * resource detection now accepts 201 and 202 * temporary fix for MgmtScopeResource test project * refine resource data * modify some test project to make it make more sense * fix last two test project * remove operation group reference in mgmtObjectType * remove some method with no-references * remove operationGroup reference in InheritanceChooser * remove operation group reference in MgmtObjectType * remove reference of ResourceIdentifierChooser * remove ResourceIdentifierChooser * decouple resourceData with OperationGroup * remove some methods with no references * remove tuple configurations since we will never use it again * refine structure of RawOperationSet * add and apply a new criteria for resources * fix supersetFlattenInheritance test project * fix sample project * correct a confusing comment * simplify * clean up commented codes * add type of id into consideration * fix test project ExactMatchFlattenInheritance * refine criteria of resource * add a new configuration to overwrite the resource type * update sample and test project * fix test cases * regenerate and refine * fix test project * fix duplicate list element * regenerate * fix test build failure * fix test accordingly * fix test failures * do not save doesresourcemodelrequirestype to configuration * refactor to make rest clients decoupled with operation groups * introduce parent detection and remove quite a lot things in Resource class * changing resource container (WIP) * in the middle of rewriting everything * Adding a new configuration to let you specify the parent of an operation path. Now you can configure the parent calculation of RequestPath struct to be non-strict. In this mode, constants will must be exactly matched, but Reference can only match its type. * move RawOperationSet to Models directory * rename RawOperationSet to OperationSet * some refactor. Introduce cache to ResourceType. Add configuration to make sure we can assign resource type via configuration. Various changes on ParameterMapping and ContextualParameterMapping * refine a comment to make it clearer * refine contextual parameter mapping to count the type in. Refine the singleton detection to make sure we will not make it a singleton when the diff path is not a constant * finishes ResourceWriter with some TODOs * finish resource container writer with multiple TODOs * clean up some stale code * refine LRO and NonLRO * refine LRO and NonLRO * some refinement and corrections on the contextual paths * comment out a lot of things to make the code could run * fix various of things * generate MgmtParent test project and it compiles * regenerate * Revert "generate MgmtParent test project and it compiles" This reverts commit 5d51952. * a huge batch of update based on the result of MgmtParent test project * resolve the list in multiple scope of one resource issue * implements the mgmt group extension * add back ArmClientExtensions * comment out the code without references * fix paging method to let it wrap resource data to resource types * some structural refactor * revert some of changes * remove some useless code and refine the name of operations * solution on extension resources like PolicyDefinition * rename a configuration to emphasize its purpose * make the resource name configurable and apply the changes to MgmtExtensionResource test project * fix how we identify the resource name of a resource is unique * apply changes to MgmtLRO * fix some issues with list method * remove the useless part in MgmtListMethods test project. The management group is now predefined in armcore, therefore we do not need to define it again in the test project in order to test list methods on mgmt groups * move the strict from the method to a property of segment. Since we cannot possibly know that whether we should use strict=false when we are comparing request paths, we put this to the property of Segment, therefore if a segment has this=false we will know this * regenerate MgmtListMethods * regenerate MgmtMultipleParentResource * implements the LRO for extension classes, also fixes some issues in LRO methods * regenerate MgmtOperations * regenerate MgmtParamOrdering * regenerate MgmtParent * remove configurations in MgmtParamOrdering * move the null check in container methods. Regenerate MgmtPropertyChooser * regenerate the checked projects * fix issues in singleton resources. Regenerate MgmtSingleton * fix some issues in rest client initialization in resource containers. regenerate OmitOperationGroups * regenerate OperationGroupMappings * regenerate Pagination * regenerate ReferenceTypes * regenerate ResourceRename * regenerate SubscriptionExtensions * fix operation name in extension class. regenerate SupersetFlattenInheritance * regenerate SupersetInheritance * regenerate TenantOnly * fix an issue in container get related methods. regenerate Azure.ResourceManager.Sample * regenerate Azure.Management.Storage, but has issues * reenable a flag to ensure that single-valued enum will be generated as a constant to ensure our logic about parenting and singleton could work properly * clean readme * support non-stringlike variables in path * organize code * implement normal list method in resource and resource container * fix normal list in extension classes * regenerate storage * refactor * fix test merge left overs * remove useless comments * remove deprecated configuration entries * initial attempt on scope resources * initial attempt for scope resource * refinement of scope resources * rename functions, fix typos * add some documents * scope test project update * Revert "scope test project update" This reverts commit 7ee5676. * some effort on the ById methods * implement the case for byId method * regenerate MgmtScopeResource * regenerate everything * fix compilation errors in test cases, and remove some useless tests * clean some dead code * fix some minor issues when generating compute * fix an edge case that a list method returns a collection of built-in types * change the way we get the name of an operation * fix the bug in list by name methods in subscription extesions * some edge case fixes * some operation name related changes * regenerate * implement the logic that makes the list methods in the extension class could find a correct resource to wrap the item into * regenerate all things * fix the issue of operation names * remove some useless code * fix parameter mapping vs fuzzy matching * fix container Id in branches * add some comments to show the request path and operation id * fix the resource type hard-code issue * fix the ById path issue * fix resource type issues * add some test code which does not affect generated content * make sure we throw exceptions when files with the same have already been written once * accumulate the errors and only throw one exception * update the way we determine resource class names * resolve the resource class name collision issue * change the resource detection logic to make we first ensure an operation set to have at least a GET operation * bring back the scope branches to the correct path * fix mgmt group contextual parameter mapping issue * no longer writes GetAllAsGenericResources if it is a scope resource container * move calculation of resource type to mgmt output library * fix the resource name issue * regenerate * remove unused code * fix a stupid error * add a new criteria to resource detection: after the providers segment, we must have even number of segments * fix sealed enum (#4) * add configuration and regenerate * feat(mgmt): backport `no-property-type-replacement` (#5) * resolve build failures in test projects * update the new extension * add a placeholder for LRO+Pageable methods * reimplement #1643 * still have some issues * escape the ienumerable when there is no GetAll * fix test case readme and regenerate * try fixing test projects * revert some unexpected changes * fixing test cases * remove listException configuration since it is automatically detected now * remove some comment and simplify * remove some dead code * feat(mgmt): detect duplicated method names (#6) 1. cache generated method names when parsing code model 2. catch duplicated method names and show error message with prompt 3. refactor `Resource` to extract a static method which can build the `operation_id` from `OperationGroup` and `Operation`. #1626 * a minor typo * Revert "remove listException configuration since it is automatically detected now" This reverts commit 30f3474. * only escape the GetAll method when it is explicitly configured * Revert "feat(mgmt): detect duplicated method names (#6)" This reverts commit c815520. * regenerate everything * regenerate * fix/skip failed test cases * introduce a new configuration mgmt-debug.suppress-list-exception * regenerate * [LLC] Use GetAll<ResourceName> for list method if ResourceName has the same plural and singular form (#1657) * fix test cases * missing a line when writing the configuration * fix * fix compile error * fix namespace of LRO objects * refactor * fix trailing spaces Co-authored-by: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com> Co-authored-by: Mingzhe Huang <archerzz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.