Skip to content

add customizations doc#1123

Merged
iscai-msft merged 10 commits intoautorestv3from
add_quickstart
Mar 14, 2022
Merged

add customizations doc#1123
iscai-msft merged 10 commits intoautorestv3from
add_quickstart

Conversation

@iscai-msft
Copy link
Contributor

@iscai-msft iscai-msft commented Jan 20, 2022

fixes #1141

```

```python
from ._models import FooGenerated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing writing this doc made me realize: we're really solidifying the file names of the generated code. I think it would be great (for version tolerant at least) to have the following names

  1. _models.py for models (we won't really need 2.7 models any more)
  2. _operations.py for operations (we already do this by default for version tolerant)
  3. _client.py for client (currently it's the name of the service client)

)

__all__ = ["ServiceClient"]
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@iscai-msft iscai-msft Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: decided to not include in this doc, at least for now. The how-to-patch-sdk-code.md doc was really good when we didn't have our customizations design, but now patch_sdk is something that we really want users to treat as "everything else has failed, so let me last ditch use patch_sdk. I've included some comment about patch_sdk in the generated code, so I think it's best to leave the customizations doc with just common customization use cases for now

@iscai-msft iscai-msft merged commit 713e4f9 into autorestv3 Mar 14, 2022
@iscai-msft iscai-msft deleted the add_quickstart branch March 14, 2022 22:55
iscai-msft added a commit that referenced this pull request Mar 14, 2022
…into raise_version_tolerant_multiapi

* 'autorestv3' of https://github.com/Azure/autorest.python:
  add customizations doc (#1123)
iscai-msft added a commit that referenced this pull request Mar 15, 2022
…into storage_to_main

* 'autorestv3' of https://github.com/Azure/autorest.python:
  raise error if multiapi and version tolerant (#1190)
  add 3.6 check and remove 3.6 incompatible future annotations import (#1188)
  add customizations doc (#1123)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Writing DPG customizations documentation

4 participants