Skip to content

correct item name of paging response model #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmazuel merged 2 commits into from
May 26, 2020
Merged

correct item name of paging response model #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e4b89a
fixed item name setting in paging operation
iscai-msft May 26, 2020
4c17674
udpated changelog
iscai-msft May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Change Log

### Unreleased
Modelerfour version: 4.13.351

**Bug Fixes**
- Corrected generation of the item name of paging response when extracting data #648

### 2020-05-22 - 5.0.0-preview.8
Modelerfour version: 4.13.351

Expand Down
3 changes: 1 addition & 2 deletions autorest/codegen/models/paging_operation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,13 @@ def item_name(self) -> str:
# Default value. I still check if I find it, so I can do a nice message.
item_name = "value"
try:
self._find_python_name(item_name, "itemName")
return self._find_python_name(item_name, "itemName")
except ValueError:
response = self._get_response()
raise ValueError(
f"While scanning x-ms-pageable, itemName was not defined and object"
+ f" {response.schema.name} has no array called 'value'"
)
return item_name
return self._find_python_name(self._item_name, "itemName")

@property
Expand Down