Make enums uppercase, but not break people accessing with lower case#692
Merged
iscai-msft merged 11 commits intoautorestv3from Jul 6, 2020
Merged
Make enums uppercase, but not break people accessing with lower case#692iscai-msft merged 11 commits intoautorestv3from
iscai-msft merged 11 commits intoautorestv3from
Conversation
…into make_enums_uppercase * 'autorestv3' of https://github.com/Azure/autorest.python: Correct variable typing in models py3 file for python 3.5 (#691) Data plane multiapi (#693) Lro and paging (iscai style) (#689)
…into make_enums_uppercase * 'autorestv3' of https://github.com/Azure/autorest.python: Update package.json Update ChangeLog.md
Member
|
@iscai-msft one last thing to check, if the enum has a "count" or "startswith" member, make sure the lowercase is the string function. Is that the case already? |
lmazuel
reviewed
Jun 26, 2020
lmazuel
approved these changes
Jul 2, 2020
iscai-msft
added a commit
that referenced
this pull request
Jul 6, 2020
…into add_http_logging_policy * 'autorestv3' of https://github.com/Azure/autorest.python: Make enums uppercase, but not break people accessing with lower case (#692)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #688