Merged
Conversation
iscai-msft
commented
Jul 20, 2020
test/vanilla/requirements.txt
Outdated
| pytest-asyncio==0.10.0;python_full_version>="3.5.2" | ||
| async_generator;python_full_version>="3.5.2" | ||
| msrest>=0.6.12 | ||
| git+https://github.com/Azure/msrest-for-python@xml_text |
Contributor
Author
There was a problem hiding this comment.
won't merge this PR until the msrest has released with the change. Will change this back before merging
iscai-msft
commented
Jul 21, 2020
| from xmlservice.models._models import Error as ErrorPy2 | ||
| assert Error == ErrorPy2 | ||
|
|
||
| def test_xms_text(self, client): |
Contributor
Author
There was a problem hiding this comment.
After #725 is merged, will add async xms-text test as well
…into x-ms-text * 'autorestv3' of https://github.com/Azure/autorest.python: add async xml tests (#725) Fix double typing (#727) Update package.json Update ChangeLog.md have operation mixin signature default to default API version (#715) custom base url with different host templates across multiapi versions (#719) default to package name for setup.py's name (#723)
lmazuel
approved these changes
Jul 28, 2020
iscai-msft
added a commit
that referenced
this pull request
Jul 28, 2020
…into single_quote * 'autorestv3' of https://github.com/Azure/autorest.python: Update ChangeLog.md Update ChangeLog.md add x-ms-text (#722)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #718
needs msrest: Azure/msrest-for-python#218
needs testsever: Azure/autorest.testserver#207