Merged
Conversation
… it was trying to discover the aio validation test
iscai-msft
commented
Aug 28, 2020
| xfail_strict=true | ||
| python_files=test_*.py |
Contributor
Author
There was a problem hiding this comment.
Added this since, without the _asnc suffix, pytest was trying to discover Validation's async service client (it would also recurse into the sync client but no errors would be thrown). The reason it discover's the Validation test's service clients is because the file name ends in test. Here, I'm just telling pytest to discover test files that start with test_
iscai-msft
commented
Aug 31, 2020
| # Change Log | ||
|
|
||
| ### 2020-xx-xx - 5.1.0-preview.8 | ||
| ### 2020-xx-xx - 5.2.0-preview.1 |
Contributor
Author
There was a problem hiding this comment.
Bumping minor version since it's a breaking change and the diff is big
lmazuel
approved these changes
Aug 31, 2020
iscai-msft
added a commit
that referenced
this pull request
Sep 9, 2020
…into improve_multiapi_api_version_error * 'autorestv3' of https://github.com/Azure/autorest.python: fix warning for BearerTokenCredentialPolicy and no credential scopes (#758) update to 4.15.416 (#761) Update ChangeLog.md remove async suffix (#759)
iscai-msft
added a commit
that referenced
this pull request
Sep 10, 2020
…into add_nullable_to_validation_map * 'autorestv3' of https://github.com/Azure/autorest.python: (41 commits) add 401 -> ClientAuthenticationError to error map (#763) NotImplementedError -> ValueError (#764) Update ChangeLog.md improve API version error (#752) fix warning for BearerTokenCredentialPolicy and no credential scopes (#758) update to 4.15.416 (#761) Update ChangeLog.md remove async suffix (#759) Handle m4 accept header parameter (#748) Multipart (#746) Introduce explode into autorest (#705) update azure-core and msrest versions (#747) Update package.json Update ChangeLog.md Replace not extend scopes (#745) Have either AzureKeyCredential typing or TokenCredential typing (#744) only add polling interval in service client doc if package has lro operations (#732) Add azure mgmt core to setup (#738) Update package.json Update ChangeLog.md ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #749