Skip to content

Add /mediatypes/binaryBodyThreeContentTypes handler#339

Merged
timotheeguerin merged 7 commits intomainfrom
chlowell/missing-mediatypes-route
Feb 25, 2022
Merged

Add /mediatypes/binaryBodyThreeContentTypes handler#339
timotheeguerin merged 7 commits intomainfrom
chlowell/missing-mediatypes-route

Conversation

@chlowell
Copy link
Member

#327 added the route to swagger/media_types.json but not a request handler for it.

@chlowell chlowell requested a review from iscai-msft February 11, 2022 21:40
};
}
});
app.post("/mediatypes/binaryBodyThreeContentTypes", "MediaTypesThreeContentTypes", (req) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this looks good, have you verified the test works locally? Also can you bump the package.json version number, we bump the version number for each test added to trigger a new release and allow people to pin to prior version numbers if necessary

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have now 😅 I had to test the text/plain route manually because autorest.go doesn't generate code for it; turns out express needed parser config for it as well.

@chlowell chlowell force-pushed the chlowell/missing-mediatypes-route branch from e1ee5b7 to 3b4f666 Compare February 22, 2022 22:55
@chlowell chlowell requested a review from iscai-msft February 23, 2022 00:55
package.json Outdated
{
"name": "@microsoft.azure/autorest.testserver",
"version": "3.2.3",
"version": "3.3.0",
Copy link
Member

@timotheeguerin timotheeguerin Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update that one again. Just increase by a patch value when tweaking the tests. It is a bit annoying you have to keep making sure your pr version bump is always up to date with the latest version of package.json

Co-authored-by: Timothee Guerin <tiguerin@microsoft.com>
@timotheeguerin timotheeguerin merged commit 8cb13da into main Feb 25, 2022
@timotheeguerin timotheeguerin deleted the chlowell/missing-mediatypes-route branch February 25, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants