Downgrade parameter_should_not_end_in_resource_group's severity to Medium#216
Merged
mmyyrroonn merged 1 commit intoAzure:masterfrom Jun 22, 2020
Merged
Conversation
fengzhou-msft
approved these changes
Jun 22, 2020
haroldrandom
approved these changes
Jun 22, 2020
Contributor
|
Is it in our Command Guide Line? Any reason why we downgrade the severity? |
Contributor
Author
It's a newly added rule and not in our Guide Line right now. I prefer to have all new rules with Medium severity in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We may need to rethink about this rule. We already met two teams want to pass this rule. Except for
--resource-group-name, there are some commands need extra resource group parameter.Azure/azure-cli#14027 destination_resource_group
Azure/azure-cli-extensions#1709 service_runtime_network_resource_group