azdev setup: show error if pip command fails#281
Merged
jiasli merged 2 commits intoAzure:masterfrom Jan 27, 2021
Merged
Conversation
jiasli
commented
Jan 25, 2021
| # install general requirements | ||
| pip_cmd( | ||
| "install -q -r {}/requirements.txt".format(cli_path), | ||
| "install -r {}".format(os.path.join(cli_path, "requirements.txt")), |
Member
Author
There was a problem hiding this comment.
Use the better function os.path.join in lieu of / join to avoid non-standard path separator on Windows:
D:\cli\azure-cli/requirements.txt -> D:\cli\azure-cli\requirements.txt
^ ^
kairu-ms
approved these changes
Jan 26, 2021
fengzhou-msft
approved these changes
Jan 26, 2021
fengzhou-msft
approved these changes
Jan 27, 2021
9 tasks
RenSilvaAU
pushed a commit
to RenSilvaAU/azure-cli-dev-tools
that referenced
this pull request
Aug 7, 2025
…reqired In generated code, a secret property will not check requirement in serialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
azdev setupsilences any error that happens. This leads to difficulties in troubleshooting installation dependencies (#274, Azure/azure-cli#16655, Azure/azure-cli#16611).pip_cmdraiseCommandErrorby default ifpipcommand fails. For other references ofpip_cmds, they assume thatpip_cmdsucceeds. Now in case of failure, bare exceptionCommandErroris raised.az setupnow supports--verboseto show the commands that are run,--debugto show the command output.