Conversation
|
|
||
| def test_benchmark_in_actual_running(self): | ||
| with mock.patch( | ||
| "multiprocessing.pool.Pool.map_async", # pylint: disable=bad-continuation |
There was a problem hiding this comment.
bad-continuation has been removed: http://pylint.pycqa.org/en/latest/whatsnew/2.6.html
| with zipfile.ZipFile(ext_file, 'r') as zip_ref: | ||
| zip_ref.extractall(ext_dir) |
There was a problem hiding this comment.
Fix:
Consider using 'with' for resource-allocating operations (consider-using-with)
| for raw_command in commands: | ||
| logger.info("Measuring %s...", raw_command) | ||
|
|
||
| # pylint: disable=consider-using-with |
There was a problem hiding this comment.
azdev/operations/performance.py is unfinished and out of maintenance.
| invalid-name, | ||
| missing-docstring, | ||
| too-many-arguments, | ||
| raise-missing-from, |
There was a problem hiding this comment.
raise-missing-from should not be forced:
W0707: Consider explicitly re-raising using the 'from' keyword (raise-missing-from)
| # For all codes, run 'pylint --list-msgs' or go to 'http://pylint-messages.wikidot.com/all-codes' | ||
| disable= | ||
| invalid-name, | ||
| cyclic-import, |
There was a problem hiding this comment.
I recommend adding explanation of why disable them.
There was a problem hiding this comment.
Good suggestion, but let's keep it for now as this is only for azdev. CLI's pylintrc has detailed explanation.
There was a problem hiding this comment.
I have removed unused items. The rest of them is self-explanatory.
| 'tox', | ||
| 'wheel==0.30.0', | ||
| 'azure-multiapi-storage', | ||
| 'isort==4.3.21' |
There was a problem hiding this comment.
Why remove 'isort==4.3.21'
3 participants
Replace #294
Bump pylint to 2.8.0 to support Python 3.9 (Azure/azure-cli#17368)