Skip to content

linter check full command group names#308

Merged
kairu-ms merged 6 commits intoAzure:devfrom
kairu-ms:linter-rule-add-top-group-help-check
Jul 5, 2021
Merged

linter check full command group names#308
kairu-ms merged 6 commits intoAzure:devfrom
kairu-ms:linter-rule-add-top-group-help-check

Conversation

@kairu-ms
Copy link
Contributor

@kairu-ms kairu-ms commented Jun 25, 2021

Currently azure cli cannot detect the miss of some command group help, because they are not as keys of command_group_table. This PR fix the issue.

@kairu-ms kairu-ms requested review from Juliehzl and jiasli June 25, 2021 13:24
@kairu-ms kairu-ms requested a review from Juliehzl June 30, 2021 05:53

0.1.34
++++++
* `azdev linter`: support to detect commmand groups which are missing in command_group_table.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR number should be added to release note.

@jiasli
Copy link
Member

jiasli commented Aug 4, 2021

To add more context to the PR:

Per my understanding, if only ad app credential exists in command_group_table, azdev linter only checks

  • ad app credential

but not

  • ad
  • ad app

This PR makes azdev check ad and ad app as well - it checks all

  • ad
  • ad app
  • ad app credential

RenSilvaAU pushed a commit to RenSilvaAU/azure-cli-dev-tools that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants