[ai-examples] Switch to a new hook#1345
Merged
jiasli merged 4 commits intoAzure:masterfrom Mar 19, 2020
mirdaki:newHookAiExamples
Merged
[ai-examples] Switch to a new hook#1345jiasli merged 4 commits intoAzure:masterfrom mirdaki:newHookAiExamples
jiasli merged 4 commits intoAzure:masterfrom
mirdaki:newHookAiExamples
Conversation
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
2 tasks
Collaborator
|
add to S166. |
Contributor
Author
jiasli
approved these changes
Mar 19, 2020
Member
|
If replacing is the desired behavior, rather than attaching, the PR looks good to me. Merging. |
Member
|
A small off-topic note: you may use the PR link directly The link will be automatically converted to Azure/azure-cli#12431. This will be clearer. 😉 |
Contributor
Author
|
Oh good to know! I'll start doing that from now on. |
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change coincides with this CLI PR to switch the help example hook. Now it directly modifies the help file examples, as opposed to just the method that printed them. This allows examples for commands that don't have any default examples (such as
az aks list) and groups.Note: As this update requires a new version of the CLI to function properly, I need to bump the minor compatible version once that new release is done. I will update the
index.jsonat that point as well.This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?