Conversation
Mossaka
requested review from
Juliehzl,
evelyn-ys,
fengzhou-msft,
houk-ms,
jiasli,
jsntcy,
kairu-ms,
msyyc,
qwordy and
zhoxing-ms
as code owners
|
hi @fengzhou-msft is this the release for installation fixing? thanks |
src/index.json
Outdated
| "pyyaml (>=5.1.0)", | ||
| "azure-identity", | ||
| "msrest (>=0.6.18)", | ||
| "azure-core (<2.0.0,>=1.8.0)", | ||
| "azure-mgmt-core (<2.0.0,>=1.2.0)", | ||
| "marshmallow (<4.0.0,>=3.5)", | ||
| "tqdm", | ||
| "azure-storage-blob (<=12.5.0,>12.0.0b4)", | ||
| "pydash (<=4.9.0)", | ||
| "azure-storage-file-share (==12.3.0)", | ||
| "pathspec (==0.8.*)", | ||
| "cryptography (<=3.3.2)" |
There was a problem hiding this comment.
Can you remove pyyaml, msrest, azure-core and azure-mgmt-core? They're already in the dependency list of azure-cli.
It is also recommended to replace azure-storage-blob and azure-storage-file-share with azure-multiapi-storage installed by azure-cli. You can refer to this PR: Azure/azure-cli#13414. @Juliehzl can help if you have any questions about storage dependency usages.
There was a problem hiding this comment.
I removed these dependencies in index.json. Do I also need to remove them in setup.py? Will ping @Juliehzl for azure-storage-blob dependency.
There was a problem hiding this comment.
You need to remove them in setup.py and regenerate the wheel and update index.json.
There was a problem hiding this comment.
After discussed with @Mossaka, the storage sdk is required by azure-ml package, not cli extension. If there is no packaging issue, I am fine with it.
There was a problem hiding this comment.
@Juliehzl LMK if there is no packaging issue.
There was a problem hiding this comment.
Removed dependencies in the CLI wheel @fengzhou-msft
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 3047 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Merge #3317 first before merging this PR. |
4 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.