EventGrid CLI extension: Updates to support new preview API version features

[kalyanaj]

Added support for new preview API version (2018-09-15-preview) functionality: Support for domain operations, advanced filters, event subscription expiration. Also, consolidated/simplified existing event subscription CRUD operation parameters to improve usability.

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

• Have you run ./scripts/ci/test_static.sh locally? (pip install pylint flake8 required)
• Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

[williexu]

Please pass CI checks

[kalyanaj]

@williexu , @tjprescott : I have resolved all the CI check issues, can you please help review this today? Also, since this depends on the Knack fix (0.4.4), should I specify the minimum version of Knack somewhere?

[tjprescott]

There's a lot of copy-paste duplication in the params.py file. You should strive to avoid this since it creates a maintenance burden moving forward. You could either:
a) extract the common info to CliArgumentTypes which you can then register at each scope

foo_type = CliArgumentType(…)
with self.argument_context('scope a') as c:
  c.argument('foo', foo_type)

with self.argument_context('scope b') as c:
  c.argument('foo', foo_type)

b) use scope to only need to register the argument once:

for scope in ['scope a', 'scope b']:
  with self.argument_context(scope) as c:
    c.argument('foo', ...)

[tjprescott]

It would be good to extract this common info to a CliCommandType so that if you have to change it later, it is changed everywhere.

[kalyanaj]

Thanks for the feedback, I have updated this now to remove this duplication.

[williexu]

@tjprescott is the CLI ready to take a dependency on knack v0.4.4?
If so, this extension can specify the new version of the CLI it is valid for once that is released.
Made a PR: Azure/azure-cli#7567

[williexu]

@kalyanaj you will need to update your azext_metadata.json to specify the minimum CLI version as 2.0.48 to rely on the new knack version.

[kalyanaj]

Thanks for the info and for PR 7567, @williexu. I will update it as you suggested once CLI 2.0.48 gets released, until then leaving it as it is so as to not blocking testing/initial release.

[kalyanaj]

@tjprescott , @williexu : I have made all the changes discussed above. Can you please review/merge if there are no additional feedback items?

[williexu]

@kalyanaj can you actually set the min cli version to 2.0.49?
We just released a hot fix version (2.0.48)

[williexu]

I can merge right after