Also allow --hostname in az ssh config#4230
Open
jacquerie-meritis wants to merge 1 commit into
Open
Conversation
|
Thank you for your contribution jacquerie-meritis! We will review the pull request and get back to you soon. |
Author
|
For completeness, I can also report that this crashes: $ azdev style ssh
Traceback (most recent call last):
File "/home/jacquerie/.local/bin/azdev", line 8, in <module>
sys.exit(main())
File "/home/jacquerie/.local/lib/python3.8/site-packages/azdev/__main__.py", line 39, in main
config_dir=get_azdev_config_dir())
File "/home/jacquerie/.local/lib/python3.8/site-packages/azdev/utilities/config.py", line 24, in get_azdev_config_dir
_, env_name = os.path.splitdrive(get_env_path())
File "/usr/lib/python3.8/posixpath.py", line 134, in splitdrive
p = os.fspath(p)
TypeError: expected str, bytes or os.PathLike object, not NoneTypeI didn't investigate further because I doubt such a small change can really be violating the style guide anyway... |
Collaborator
|
ssh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to
az ssh vm,az ssh configshould also accept using the--hostnameform of the argument as well as--ip. See:azure-cli-extensions/src/ssh/azext_ssh/_params.py
Lines 11 to 12 in 5f48738
And:
azure-cli-extensions/src/ssh/azext_ssh/_params.py
Line 27 in 5f48738
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.