Skip to content

[CosmosDB]: az cosmosdb dts: Add cosmos db data transfer commands#4563

Merged
evelyn-ys merged 16 commits into
Azure:mainfrom
niteshvijay1995:dts-public-preview
May 12, 2022
Merged

[CosmosDB]: az cosmosdb dts: Add cosmos db data transfer commands#4563
evelyn-ys merged 16 commits into
Azure:mainfrom
niteshvijay1995:dts-public-preview

Conversation

@niteshvijay1995
Copy link
Copy Markdown
Member

@niteshvijay1995 niteshvijay1995 commented Mar 23, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Mar 23, 2022

cosmosdb

Comment thread src/cosmosdb-preview/azext_cosmosdb_preview/custom.py Outdated
Comment thread src/cosmosdb-preview/azext_cosmosdb_preview/commands.py Outdated
@calvinhzy
Copy link
Copy Markdown
Member

Please add some tests if possible.

Comment thread src/cosmosdb-preview/azext_cosmosdb_preview/_params.py Outdated
Comment thread src/cosmosdb-preview/azext_cosmosdb_preview/commands.py Outdated
@evelyn-ys
Copy link
Copy Markdown
Member

  1. Please add tests for newly added commands.
  2. Don't forget to update version in setup.py and History.rst

@niteshvijay1995 niteshvijay1995 changed the title Add DTS commands [CosmosDB]: az cosmosdb dts: Add cosmos db data transfer commands Mar 30, 2022
@niteshvijay1995
Copy link
Copy Markdown
Member Author

Added tests

Comment thread src/cosmosdb-preview/azext_cosmosdb_preview/_help.py
Comment thread src/cosmosdb-preview/azext_cosmosdb_preview/_help.py
Comment thread src/cosmosdb-preview/azext_cosmosdb_preview/_help.py
Comment thread src/cosmosdb-preview/azext_cosmosdb_preview/_help.py
Comment thread src/cosmosdb-preview/azext_cosmosdb_preview/_help.py
Copy link
Copy Markdown
Member

@evelyn-ys evelyn-ys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general

@evelyn-ys evelyn-ys merged commit c8dedfa into Azure:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants