A PoC of support SSH Cert inside Cloud Shell#4641
Closed
rayluo wants to merge 1 commit intoAzure:mainfrom
Closed
Conversation
Collaborator
|
support SSH Cert |
jiasli
reviewed
Apr 7, 2022
| credential, _, _ = profile.get_login_credentials(subscription_id=profile.get_subscription()["id"]) | ||
| certificatedata = credential.get_token(*scopes, data=data) | ||
| certificate = certificatedata.token | ||
| if RUNNING_INSIDE_CLOUDSHELL: |
Member
There was a problem hiding this comment.
Running inside Cloud Shell doesn't mean this is a Cloud Shell account. User may manually run az login to override the Cloud Shell account.
It seems we can't bypass CLI core, which has more checks
if in_cloud_console() and account[_USER_ENTITY].get(_CLOUD_SHELL_ID):
Author
|
Replaced by Azure/azure-cli#22162 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept to acquire SSH Cert from inside Cloud Shell.
Prerequisite: An MSAL prototype from this PR AzureAD/microsoft-authentication-library-for-python#420
@jiasli