Containerapp 0.3.6 release #4879
Merged
Merged
Conversation
ghost
requested a review
from 
ghost
added
the
Collaborator
|
Containerapp |
* Added environment as flag for list_containerapp. * Fixed logic error in RID case. * Check if rg exists. * Validate managed env exists if group is passed or rid is passed. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
* Integer division to update existing weights. Validate revision names. * Added revision label add ability to reuse existing label. * Fixed style issues. * Removed deprecated _round function in utils. * Added revision label swap. * Revision list only shows active revisions by default. Use flag --all to show inactive revisions as well. * Updated history. * Changed to use --labels instead of label1,label2. Added util to check if traffic payload less than 4096 bytes. * Added label check in traffic set. * Updated history. * Removed 4096byte util. * Added help for label swap, fixed styling. * Added test for revision labels. Fixed help typo. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
* Updated enum. * Updated history. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
* Updated error handling. * Made sure key retrieval had a try catch. * Added error handling for --logs-customer-id only case. * Updated error handling of _ensure_location_allowed. * Default providers_client to None. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
* Fix microsoft/azure-container-apps#234 * Added history note. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> Co-authored-by: Haroon Feisal <38823870+haroonf@users.noreply.github.com>
2 tasks
* show api error message for invalid cert name * hide prompt as default & surface api response * rename --prompt * added BREAKING CHANGE bullet to history.rst Co-authored-by: Haroon Feisal <38823870+haroonf@users.noreply.github.com>
panchagnula
reviewed
Jun 6, 2022
panchagnula
reviewed
Jun 6, 2022
panchagnula
reviewed
Jun 6, 2022
panchagnula
reviewed
Jun 6, 2022
panchagnula
reviewed
Jun 6, 2022
panchagnula
reviewed
Jun 6, 2022
…rce, --target. (#123) * Changed --labels to --source-label, target-label. * Dropped -label from params in label swap. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
…xtensions into containerapp-0.3.6
MSI auth for `az containerapp registry set`
Contributor
|
@zhoxing-ms can we get your initial review as well, so we can ship these changes soon. Thanks! |
zhoxing-ms
reviewed
Jun 7, 2022
zhoxing-ms
reviewed
Jun 7, 2022
zhoxing-ms
reviewed
Jun 7, 2022
zhoxing-ms
reviewed
Jun 7, 2022
zhoxing-ms
reviewed
Jun 7, 2022
zhoxing-ms
approved these changes
Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.