[Compute] Fix #5258: az image copy: Fix expected not NoneType error#5274
Merged
Conversation
ghost
requested review from
ghost
added
the
Collaborator
|
Compute |
zhoxing-ms
reviewed
Aug 26, 2022
yanzhudd
force-pushed
the
fix_image_copy
branch
from
86c8e04 to
01849fd
Compare
…ry.rst and setup.py
zhoxing-ms
approved these changes
Aug 29, 2022
wangzelin007
approved these changes
Aug 30, 2022
…into fix_image_copy
zhoxing-ms
approved these changes
Nov 30, 2022
Collaborator
|
[Release] Update index.json for extension [ image-copy ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=18035&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Description
The logic of
az image copycommand is consisted by several Azure CLI commands. Theaz image showcommand is called first, and then the fields in the output will be used to call other commands later.This error mainly due to the
hyperVGenerationfield ofaz image showcommand output is null value and then passed to call other commands.Issue - close: #5258
Related command
az image copyGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.