Conversation
added 2 commits
September 13, 2022 17:01
huizhifan
requested review from
FumingZhang and
andyliuliming
as code owners
Contributor
Author
|
Kicked off a pipeline to generate the recording file though not sure if I did it right. |
Collaborator
|
AKS |
FumingZhang
reviewed
Sep 15, 2022
Member
xiazhan
reviewed
Sep 15, 2022
| if self.context.get_enable_vpa(): | ||
| if mc.workload_auto_scaler_profile is None: | ||
| mc.workload_auto_scaler_profile = self.models.ManagedClusterWorkloadAutoScalerProfile() | ||
| mc.workload_auto_scaler_profile.vertical_pod_autoscaler = self.models.ManagedClusterWorkloadAutoScalerProfileVerticalPodAutoscaler(enable=True) |
Contributor
There was a problem hiding this comment.
Check if mc.workload_auto_scaler_profile.vertical_pod_autoscaler is None?
Contributor
Author
There was a problem hiding this comment.
Updated in the latest iteration
Member
FumingZhang
reviewed
Sep 16, 2022
zhoxing-ms
approved these changes
Sep 16, 2022
Collaborator
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1854690&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create --enable-vpa
az aks update --enable-vpa
az
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.