{AKS} add support for updating kube-proxy configuration#5545
Merged
Conversation
Collaborator
|
AKS |
FumingZhang
reviewed
Nov 15, 2022
FumingZhang
reviewed
Nov 15, 2022
4fc6461 to
938a8b3
Compare
FumingZhang
reviewed
Nov 16, 2022
FumingZhang
reviewed
Nov 18, 2022
Member
FumingZhang
left a comment
There was a problem hiding this comment.
LGTM, queued a pipeline to validate newly added tests.
Contributor
Author
|
@FumingZhang may need to rerun pipeline after |
Contributor
|
@mattstam Could you please resolve the conflict? |
FumingZhang
reviewed
Nov 22, 2022
f54b8c4 to
67b0c9e
Compare
Member
|
Queued a new pipeline to verify these 2 cases
All passed. Please commit the new recording files, may find them from pipeline artifact. |
zhoxing-ms
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Support updating kube-proxy configuration with 'az aks update --kube-proxy-config file.json'
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.