Skip to content

[connectedvmware] Bump up api version, add vm retain support #5556

Merged
zhoxing-ms merged 3 commits into
Azure:mainfrom
nascarsayan:dev/snaskar/bump-api-version-add-retain
Nov 24, 2022
Merged

[connectedvmware] Bump up api version, add vm retain support #5556
zhoxing-ms merged 3 commits into
Azure:mainfrom
nascarsayan:dev/snaskar/bump-api-version-add-retain

Conversation

@nascarsayan
Copy link
Copy Markdown
Contributor

@nascarsayan nascarsayan commented Nov 16, 2022

Bumping up the API version from 2020-10-01-preview to 2022-01-10-preview, as we need access to the retain query parameter for VM delete in the az subcommand.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from yonzhan and zhoxing-ms November 16, 2022 16:18
@ghost ghost added the Auto-Assign Auto assign by bot label Nov 16, 2022
@ghost ghost requested a review from wangzelin007 November 16, 2022 16:18
@ghost ghost assigned zhoxing-ms Nov 16, 2022
@ghost ghost added this to the Nov 2022 (2022-12-06) milestone Nov 16, 2022
@ghost ghost added the Compute label Nov 16, 2022
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Nov 16, 2022

connectedvmware

@nascarsayan nascarsayan marked this pull request as ready for review November 20, 2022 08:02
@zhoxing-ms
Copy link
Copy Markdown
Contributor

Could you add new tests for this new parameter?

@zhoxing-ms
Copy link
Copy Markdown
Contributor

zhoxing-ms commented Nov 22, 2022

Do you want to release a new extension version for this PR change? If so, please add the description of the new parameter into the HISTORY.rst and upgrade the version defined in the setup.py

@nascarsayan
Copy link
Copy Markdown
Contributor Author

Could you add new tests for this new parameter?

@zhoxing-ms , Have added tests for the new parameter. Also, have increased the extension build number.

@zhoxing-ms zhoxing-ms merged commit 5501a71 into Azure:main Nov 24, 2022
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ connectedvmware ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=16816&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Compute

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants