Skip to content

[AKS] Mark AAD-legacy properties deprecated #5670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoxing-ms merged 1 commit into from
Feb 3, 2023
Merged

[AKS] Mark AAD-legacy properties deprecated #5670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ To release a new version, please select a new version number (usually plus 1 to
Pending
+++++++

* Mark AAD-legacy properties `--aad-client-app-id`, `--aad-server-app-id` and `--aad-server-app-secret` deprecated

0.5.128
+++++++
* Fix option name `--duration` for command group `az aks maintenanceconfiguration`
Expand Down
3 changes: 3 additions & 0 deletions src/aks-preview/azext_aks_preview/_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,16 @@
type: string
short-summary: The ID of an Azure Active Directory client application of type "Native". This
application is for user login via kubectl.
long-summary: --aad-client-app-id is deprecated. See https://aka.ms/aks/aad-legacy for details.
- name: --aad-server-app-id
type: string
short-summary: The ID of an Azure Active Directory server application of type "Web app/API". This
application represents the managed cluster's apiserver (Server application).
long-summary: --aad-server-app-id is deprecated. See https://aka.ms/aks/aad-legacy for details.
- name: --aad-server-app-secret
type: string
short-summary: The secret of an Azure Active Directory server application.
long-summary: --aad-server-app-secret is deprecated. See https://aka.ms/aks/aad-legacy for details.
- name: --aad-tenant-id
type: string
short-summary: The ID of an Azure Active Directory tenant.
Expand Down
6 changes: 3 additions & 3 deletions src/aks-preview/azext_aks_preview/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,9 +294,9 @@ def load_arguments(self, _):
c.argument('assign_kubelet_identity', validator=validate_assign_kubelet_identity)
c.argument('enable_aad', action='store_true')
c.argument('enable_azure_rbac', action='store_true')
c.argument('aad_client_app_id')
c.argument('aad_server_app_id')
c.argument('aad_server_app_secret')
c.argument('aad_client_app_id', deprecate_info=c.deprecate(target='--aad-client-app-id', hide=True))
Comment thread
bingosummer marked this conversation as resolved.
Outdated
c.argument('aad_server_app_id', deprecate_info=c.deprecate(target='--aad-server-app-id', hide=True))
c.argument('aad_server_app_secret', deprecate_info=c.deprecate(target='--aad-server-app-secret', hide=True))
c.argument('aad_tenant_id')
c.argument('aad_admin_group_object_ids')
c.argument('enable_oidc_issuer', action='store_true')
Expand Down