[staticwebapp] Add Static Web App extension #5819
Conversation
|
staticwebapp |
| @classmethod | ||
| def _validate(cls, sku: 'Sku', connection_type: 'ConnectionType', database_name, username, password): | ||
| if not cls._is_supported(sku, connection_type): | ||
| raise ValidationError(f"Authentication type '{connection_type}' is not supported for " |
There was a problem hiding this comment.
It is better to point out what types are supported.
There was a problem hiding this comment.
Thanks for the suggestion, just added that
Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
I see that the CI pipeline of this PR failed due to the inconsistent api-version of |
…ection types on validation error
|
[Release] Update index.json for extension [ staticwebapp ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=41438&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.