Skip to content

[confcom] Add confcom extension#5833

Merged
jsntcy merged 11 commits into
Azure:mainfrom
SethHollandsworth:confcom-onboarding
Feb 17, 2023
Merged

[confcom] Add confcom extension#5833
jsntcy merged 11 commits into
Azure:mainfrom
SethHollandsworth:confcom-onboarding

Conversation

@SethHollandsworth
Copy link
Copy Markdown
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az confcom

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Feb 2, 2023

confcom

@yonzhan yonzhan requested review from jsntcy and kairu-ms February 2, 2023 23:07
@yonzhan yonzhan added this to the Feb 2023 (2023-03-07) milestone Feb 2, 2023
@SethHollandsworth SethHollandsworth changed the title initial commit for adding confcom [confcom] Add confcom extension Feb 3, 2023
@SethHollandsworth SethHollandsworth force-pushed the confcom-onboarding branch 3 times, most recently from 62b9d5c to 434c448 Compare February 7, 2023 19:33
@kairu-ms
Copy link
Copy Markdown
Contributor

Could you fix the failed tests?

@jsntcy
Copy link
Copy Markdown
Member

jsntcy commented Feb 15, 2023

@SethHollandsworth, please fix test failure first.

@SethHollandsworth
Copy link
Copy Markdown
Contributor Author

Thanks, the failed test was because of a recent feature branch. They are fixed now

@jsntcy jsntcy merged commit 1a55093 into Azure:main Feb 17, 2023
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ confcom ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=34891&view=results

@SethHollandsworth SethHollandsworth deleted the confcom-onboarding branch May 16, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants