Skip to content

[dataprotection] Release 0.7.0#5882

Merged
wangzelin007 merged 1 commit into
Azure:mainfrom
wangzelin007:fix-dataprotectsion
Feb 15, 2023
Merged

[dataprotection] Release 0.7.0#5882
wangzelin007 merged 1 commit into
Azure:mainfrom
wangzelin007:fix-dataprotectsion

Conversation

@wangzelin007
Copy link
Copy Markdown
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested a review from yonzhan February 15, 2023 03:20
@ghost ghost added the Auto-Assign Auto assign by bot label Feb 15, 2023
@ghost ghost requested a review from evelyn-ys February 15, 2023 03:20
@ghost ghost assigned evelyn-ys Feb 15, 2023
@ghost ghost added this to the Feb 2023 (2023-03-07) milestone Feb 15, 2023
@ghost ghost added the Data Protection label Feb 15, 2023
@ghost ghost requested a review from calvinhzy February 15, 2023 03:20
@wangzelin007
Copy link
Copy Markdown
Member Author

wangzelin007 commented Feb 15, 2023

Hi @zubairabid,
Maybe we should delete azure-cli-extensions\src\dataprotection\azext_dataprotection\manual\version.py and use the version in the setup.py file directly.

@zubairabid
Copy link
Copy Markdown
Contributor

Hi @zubairabid, Maybe we should delete azure-cli-extensions\src\dataprotection\azext_dataprotection\manual\version.py and use the version in the setup.py file directly.

Hi @wangzelin007 that should be alright. Are there any downsides to that?

@wangzelin007
Copy link
Copy Markdown
Member Author

wangzelin007 commented Feb 15, 2023

Hi @wangzelin007 that should be alright. Are there any downsides to that?

Hi @zubairabid
I don't think there are downsides, I checked the code, only setup.py uses manual.version.

@wangzelin007 wangzelin007 merged commit 832b083 into Azure:main Feb 15, 2023
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ dataprotection ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=34190&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants