Update image tag used for "no Dockerfile" containerapp up scenario#5913
Closed
cormacpayne wants to merge 1 commit into
Closed
Update image tag used for "no Dockerfile" containerapp up scenario#5913cormacpayne wants to merge 1 commit into
cormacpayne wants to merge 1 commit into
Conversation
Member
Author
|
CC: @StrawnSC |
Collaborator
|
containerapp |
Contributor
|
Blocked until #5894 is merged |
howang-ms
approved these changes
Mar 8, 2023
zhoxing-ms
approved these changes
Mar 8, 2023
Contributor
Contributor
|
@cormacpayne can we go ahead and close this since this change will go out in #5955? |
Member
Author
|
@StrawnSC thanks for the heads up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to update the Oryx build image tag used by the
az containerapp upcommand to construct aDockerfilefor the user when the provided--sourcecode does not contain aDockerfileitself.The new image tag will enable the latest versions of supported Oryx platform binaries to be pulled down dynamically when building the
--source, as well as enable telemetry on the Oryx end.This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp upGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
- [ ] My extension description/summary conforms to the Extension Summary Guidelines.About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.