Skip to content

Update image tag used for "no Dockerfile" containerapp up scenario#5913

Closed
cormacpayne wants to merge 1 commit into
Azure:mainfrom
cormacpayne:corm/update-container-app-oryx-tag
Closed

Update image tag used for "no Dockerfile" containerapp up scenario#5913
cormacpayne wants to merge 1 commit into
Azure:mainfrom
cormacpayne:corm/update-container-app-oryx-tag

Conversation

@cormacpayne
Copy link
Copy Markdown
Member

This PR aims to update the Oryx build image tag used by the az containerapp up command to construct a Dockerfile for the user when the provided --source code does not contain a Dockerfile itself.

The new image tag will enable the latest versions of supported Oryx platform binaries to be pulled down dynamically when building the --source, as well as enable telemetry on the Oryx end.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp up

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

- [ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested a review from yonzhan February 23, 2023 01:08
@ghost ghost added the Auto-Assign Auto assign by bot label Feb 23, 2023
@ghost ghost requested a review from wangzelin007 February 23, 2023 01:08
@ghost ghost assigned zhoxing-ms Feb 23, 2023
@ghost ghost added this to the Feb 2023 (2023-03-07) milestone Feb 23, 2023
@ghost ghost added the ContainerApp label Feb 23, 2023
@ghost ghost requested review from jsntcy and zhoxing-ms February 23, 2023 01:08
@cormacpayne
Copy link
Copy Markdown
Member Author

CC: @StrawnSC

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Feb 23, 2023

containerapp

@yonzhan yonzhan requested a review from yanzhudd February 23, 2023 03:42
@StrawnSC
Copy link
Copy Markdown
Contributor

Blocked until #5894 is merged

@zhoxing-ms
Copy link
Copy Markdown
Contributor

@StrawnSC Since #5894 was merged, could we merge this PR now?

@StrawnSC
Copy link
Copy Markdown
Contributor

StrawnSC commented Mar 8, 2023

@cormacpayne can we go ahead and close this since this change will go out in #5955?

@cormacpayne cormacpayne closed this Mar 8, 2023
@cormacpayne
Copy link
Copy Markdown
Member Author

@StrawnSC thanks for the heads up! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants