Skip to content

add network aaz cmd needed for ssh#5945

Merged
AllyW merged 7 commits into
Azure:mainfrom
AllyW:network-sdk-replace
Mar 14, 2023
Merged

add network aaz cmd needed for ssh#5945
AllyW merged 7 commits into
Azure:mainfrom
AllyW:network-sdk-replace

Conversation

@AllyW
Copy link
Copy Markdown
Contributor

@AllyW AllyW commented Mar 6, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az ssh vm
az ssh config

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@ghost ghost added Auto-Assign Auto assign by bot VM SSH labels Mar 6, 2023
@ghost ghost requested review from jiasli and yonzhan March 6, 2023 12:42
@ghost ghost assigned jiasli Mar 6, 2023
@ghost ghost added this to the March 2023 (2023-04-04) milestone Mar 6, 2023
@ghost ghost added the Spring Cloud Spring Cloud related issues label Mar 6, 2023
@ghost ghost requested review from wangzelin007 and zhoxing-ms March 6, 2023 12:42
@ghost ghost assigned zhoxing-ms Mar 6, 2023
@ghost ghost requested review from jsntcy, kairu-ms and necusjz March 6, 2023 12:43
@ghost ghost assigned necusjz Mar 6, 2023
@AllyW AllyW assigned AllyW and unassigned jiasli, necusjz and zhoxing-ms Mar 6, 2023
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Mar 6, 2023

network upgrade

Copy link
Copy Markdown
Contributor

@kairu-ms kairu-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump up extension versions are required for extension release.

Comment thread src/spring-cloud/azext_spring_cloud/_validators.py Outdated
Comment thread src/spring/azext_spring/_validators.py Outdated
Comment thread src/ssh/azext_ssh/ip_utils.py Outdated
Comment thread src/ssh/azext_ssh/ip_utils.py Outdated
Comment thread src/ssh/azext_ssh/ip_utils.py Outdated
@AllyW AllyW changed the title add network aaz cmd needed for ssh, spring and spring-cloud add network aaz cmd needed for ssh Mar 13, 2023
Comment thread src/ssh/azext_ssh/ip_utils.py Outdated
Copy link
Copy Markdown
Contributor

@kairu-ms kairu-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Please clean up the commented lines of code.

@AllyW AllyW merged commit ebba286 into Azure:main Mar 14, 2023
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ ssh ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=41228&view=results

@AllyW AllyW deleted the network-sdk-replace branch February 28, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Compute Network Spring Cloud Spring Cloud related issues VM SSH

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants