Skip to content

{AKS} az aks trustedaccess rolebinding create: Change the short name of option --source-resource-id to -r#5949

Merged
zhoxing-ms merged 4 commits into
Azure:mainfrom
FumingZhang:fuming/ta-param-0307
Mar 13, 2023
Merged

{AKS} az aks trustedaccess rolebinding create: Change the short name of option --source-resource-id to -r#5949
zhoxing-ms merged 4 commits into
Azure:mainfrom
FumingZhang:fuming/ta-param-0307

Conversation

@FumingZhang
Copy link
Copy Markdown
Member

@FumingZhang FumingZhang commented Mar 7, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Change the short name of option --source-resource-id in command az aks trustedaccess rolebinding create from -s to -r.
The deprecated short name -s is hidden by default and will be completely removed when aks-preview's dependency on the cli core version is updated to 2.47.0. For current dependency, see doc.

image
image

Related command

  • az aks trustedaccess rolebinding create

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@ghost ghost requested review from yanzhudd and zhoxing-ms March 7, 2023 03:14
@ghost ghost assigned zhoxing-ms Mar 7, 2023
@ghost ghost added this to the March 2023 (2023-04-04) milestone Mar 7, 2023
@ghost ghost added the Auto-Assign Auto assign by bot label Mar 7, 2023
@ghost ghost requested a review from yonzhan March 7, 2023 03:14
@ghost ghost added the AKS label Mar 7, 2023
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Mar 7, 2023

AKS

@FumingZhang
Copy link
Copy Markdown
Member Author

FumingZhang commented Mar 7, 2023

Failed test not related to the changes in this PR, opened PR #5951 to fix the issue.

@FumingZhang FumingZhang force-pushed the fuming/ta-param-0307 branch from a0c4a4c to b98179b Compare March 7, 2023 07:24
@FumingZhang FumingZhang marked this pull request as ready for review March 7, 2023 07:56
Comment thread src/aks-preview/azext_aks_preview/_params.py Outdated
@zhoxing-ms zhoxing-ms merged commit 59453c9 into Azure:main Mar 13, 2023
@FumingZhang FumingZhang deleted the fuming/ta-param-0307 branch April 10, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants