Skip to content

replace network sdk for spring#5971

Merged
AllyW merged 5 commits into
Azure:mainfrom
AllyW:network-sdk-spring
Mar 14, 2023
Merged

replace network sdk for spring#5971
AllyW merged 5 commits into
Azure:mainfrom
AllyW:network-sdk-spring

Conversation

@AllyW
Copy link
Copy Markdown
Contributor

@AllyW AllyW commented Mar 10, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az spring create

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@ghost ghost requested review from jsntcy, kairu-ms and yonzhan March 10, 2023 14:19
@ghost ghost added the Auto-Assign Auto assign by bot label Mar 10, 2023
@ghost ghost requested a review from necusjz March 10, 2023 14:19
@ghost ghost assigned necusjz Mar 10, 2023
@ghost ghost added this to the March 2023 (2023-04-04) milestone Mar 10, 2023
@ghost ghost added the Network label Mar 10, 2023
@AllyW AllyW assigned AllyW and unassigned necusjz Mar 10, 2023
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Mar 11, 2023

network upgrade

Comment thread src/spring/azext_spring/_validators.py Outdated
Comment thread src/spring/azext_spring/_validators.py Outdated
@AllyW AllyW merged commit 6dbe8e0 into Azure:main Mar 14, 2023
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ spring ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=41259&view=results

from azure.cli.core.aaz import has_value
args = self.ctx.args
if has_value(args.subscription_id):
self.ctx._subscription_id = args.subscription_id
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.ctx._subscription_id = args.subscription_id.to_serialized_data()

@AllyW AllyW deleted the network-sdk-spring branch February 28, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Network

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants