[confcom] bugfixes for using sha values and tar files#5987
Merged
Conversation
Feature/approve wildcards
…-wide making layer caching work across multiple container groups
adding a couple bug fixes for using sha hashes
hgarvison
approved these changes
Mar 14, 2023
stevendongatmsft
approved these changes
Mar 14, 2023
Collaborator
|
confcom |
kairu-ms
approved these changes
Mar 15, 2023
Collaborator
|
[Release] Update index.json for extension [ confcom ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=41424&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
confcom
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?Description
Bugfix to make sha hashes work better. Fixed a bug where it would error if you specified a hash but not a tag name. Also moved the error checking to make sure you're not trying to use a hash on a tar file.
Right now, caching only works if you're doing multiple of the same image within the same container group. This PR will make it so it's template-wide which is a more reasonable and helpful mechanism.