Skip to content

{AKS} Update cli tests disable upgrade node image related tests#5989

Merged
zhoxing-ms merged 3 commits into
Azure:mainfrom
yewmsft:main
Mar 15, 2023
Merged

{AKS} Update cli tests disable upgrade node image related tests#5989
zhoxing-ms merged 3 commits into
Azure:mainfrom
yewmsft:main

Conversation

@yewmsft
Copy link
Copy Markdown
Member

@yewmsft yewmsft commented Mar 14, 2023


Current cli tests which involves node image upgrades are not meaningful. These tests is relying on a buggish behavior in upgradeNodeImageVersion API to function. If we are upgrading the node image of an agent pool which is already on the latest node image version, upgradeNodeImageVersion API will exit silently after very long validation on the async side.

Existing nodeimageupgrade related cli tests are all trying to upgrade the node image of clusters which is already on the latest image version. And it only checks if the agent pool goes into UpgradingNodeImageVersion provisioningState. It never verifies whether the upgrade succeeded or not, which make these tests meaningless.

After changing upgradeNodeImageVersion API to return 304 when agent pool is already on the latest version. These tests will stop function. Temporarily disable node image upgrade tests to unblock RP release. We will provide a short term solution in RP to re-enable these tests first. And after we have the API to create clusters with an older image, we will redo these tests to make real node image upgrades.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

N/A, tests only

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@ghost ghost requested review from yanzhudd and zhoxing-ms March 14, 2023 16:47
@ghost ghost assigned zhoxing-ms Mar 14, 2023
@ghost ghost added this to the March 2023 (2023-04-04) milestone Mar 14, 2023
@ghost ghost added the Auto-Assign Auto assign by bot label Mar 14, 2023
@ghost ghost requested a review from yonzhan March 14, 2023 16:47
@ghost ghost added the AKS label Mar 14, 2023
@yewmsft yewmsft changed the title [AKS] Fix cli tests, expecting upgrade node image command to return error [AKS] Update cli tests to stop calling upgrade node image command Mar 14, 2023
@yewmsft yewmsft changed the title [AKS] Update cli tests to stop calling upgrade node image command [AKS] Update cli tests disable upgrade node image related tests Mar 14, 2023
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Mar 14, 2023

AKS

@FumingZhang FumingZhang changed the title [AKS] Update cli tests disable upgrade node image related tests {AKS} Update cli tests disable upgrade node image related tests Mar 15, 2023
@zhoxing-ms zhoxing-ms merged commit 25ab130 into Azure:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants