Skip to content

{mobile-network} az mobile-network site: Fix example error#6066

Merged
jsntcy merged 4 commits into
Azure:mainfrom
Jing-song:jins-moble-nt-example
Mar 27, 2023
Merged

{mobile-network} az mobile-network site: Fix example error#6066
jsntcy merged 4 commits into
Azure:mainfrom
Jing-song:jins-moble-nt-example

Conversation

@Jing-song
Copy link
Copy Markdown
Contributor

@Jing-song Jing-song commented Mar 24, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az mobile-network site Fix example error
update aaz model: Azure/aaz#159
close Azure/azure-cli#25919

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Jing-song Jing-song requested a review from jsntcy as a code owner March 24, 2023 04:59
@ghost ghost requested review from kairu-ms and yonzhan March 24, 2023 04:59
@ghost ghost added the Auto-Assign Auto assign by bot label Mar 24, 2023
@ghost ghost requested a review from necusjz March 24, 2023 05:00
@ghost ghost assigned necusjz Mar 24, 2023
@ghost ghost added the Network label Mar 24, 2023
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Mar 24, 2023

mobile-network

@jsntcy
Copy link
Copy Markdown
Member

jsntcy commented Mar 24, 2023

@Jing-song, you may also update https://github.com/Azure/aaz/tree/main/Commands/mobile-network as well.
BTW, please fix tests first.

@Jing-song
Copy link
Copy Markdown
Contributor Author

Jing-song commented Mar 24, 2023

@Jing-song, you may also update https://github.com/Azure/aaz/tree/main/Commands/mobile-network as well. BTW, please fix tests first.

Update aaz here: Azure/aaz#159

@jsntcy
Copy link
Copy Markdown
Member

jsntcy commented Mar 24, 2023

@Jing-song, please update extension version as well in both setup.py and history.rst.

@jsntcy jsntcy merged commit d7fa097 into Azure:main Mar 27, 2023
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ mobile-network ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=43771&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Network

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mobil-network: Wrong site create command in the Examples

5 participants