Skip to content

Fix managed certs validation prompt#6189

Merged
zhoxing-ms merged 6 commits into
Azure:mainfrom
lil131:fix-mc-validation-prompt
Apr 23, 2023
Merged

Fix managed certs validation prompt#6189
zhoxing-ms merged 6 commits into
Azure:mainfrom
lil131:fix-mc-validation-prompt

Conversation

@lil131
Copy link
Copy Markdown
Member

@lil131 lil131 commented Apr 10, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

containerapp

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@ghost ghost requested a review from yonzhan April 10, 2023 21:50
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 10, 2023
@ghost ghost requested a review from wangzelin007 April 10, 2023 21:50
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Apr 10, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@ghost ghost requested a review from yanzhudd April 10, 2023 21:50
@ghost ghost assigned zhoxing-ms Apr 10, 2023
@ghost ghost added the ContainerApp label Apr 10, 2023
@ghost ghost requested review from jsntcy and zhoxing-ms April 10, 2023 21:50
@lil131 lil131 changed the title Fix managed certs validation prompt and release Containerapp 0.3.28 Fix managed certs validation prompt Apr 18, 2023
Comment thread src/containerapp/azext_containerapp/custom.py
@zhoxing-ms
Copy link
Copy Markdown
Contributor

If you want to release a new version for this extension, please also upgrade the version defined in setup.py

@lil131
Copy link
Copy Markdown
Member Author

lil131 commented Apr 19, 2023

If you want to release a new version for this extension, please also upgrade the version defined in setup.py

We decided not to bump the version in this PR. Should I mark the notes of changes in History.rst as "Upcoming"?

@zhoxing-ms
Copy link
Copy Markdown
Contributor

We decided not to bump the version in this PR. Should I mark the notes of changes in History.rst as "Upcoming"?

Yes, sounds good!

@lil131
Copy link
Copy Markdown
Member Author

lil131 commented Apr 21, 2023

We decided not to bump the version in this PR. Should I mark the notes of changes in History.rst as "Upcoming"?

Yes, sounds good!

Marked as Upcoming. Could you please take another look when you get a chance? Thanks!

@lil131 lil131 requested a review from zhoxing-ms April 21, 2023 23:43
@zhoxing-ms zhoxing-ms merged commit 1c8e516 into Azure:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants