mount secret volume cli#6223
Conversation
|
Hi @smzeng, |
|
Hi @smzeng, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
xwang971
left a comment
There was a problem hiding this comment.
Can we add some explanations on help.py?
…m/smzeng/azure-cli-extensions into stacyzeng/mount-secret-volume-cli
…m/smzeng/azure-cli-extensions into stacyzeng/mount-secret-volume-cli
merge main into remote
|
if you wish to test the changes you can use this demo cli by running the following command, just remember to downgrade back to normal version after :) example commands/yaml can be found at the end of this file https://microsoft-my.sharepoint.com/:w:/p/stacyzeng/EXw3LayK-BNMh3qa4usyUCAB9VcR-GBsUWlytV25iE6VWg?e=fWcVkr |
|
@yonzhan hi this is ready to be merged |
|
@zhoxing-ms hi, this is ready to be reviewed, hoping to get this merged by the end of the month :) |
| class ContainerAppMountSecretTest(ScenarioTest): | ||
| @AllowLargeResponse(8192) | ||
| @ResourceGroupPreparer(location="northcentralus") | ||
| @live_only() # encounters 'CannotOverwriteExistingCassetteException' only when run from recording (passes when run live) |
There was a problem hiding this comment.
Could you please provide specific error message? We can try to see if we can solve this issue
There was a problem hiding this comment.
sorry this comment was copied over from the Ingress Sticky Sessions Test (
.
ContainerAppMountSecretTest works both live and not live, I have removed @liveonly from mount secret test
There was a problem hiding this comment.
The specific error message that is seen by the Ingress Sticky session is and occurs at line 28 (
ex = CannotOverwriteExistingCassetteException("Can't overwrite existing cassette ('/home/stacyzeng/azure-cli-extensions/src...d', 'scheme', 'host', 'port', 'path']\nMatchers failed :\n_custom_request_query_matcher - assertion failure :\nNone\n")
def _polish_bad_errors(ex):
import json
try:
content = json.loads(ex.response.content)
if 'message' in content:
detail = content['message']
elif 'Message' in content:
detail = content['Message']
ex = CLIInternalError(detail)
except Exception: # pylint: disable=broad-except
pass
if no_throw:
return ex
> raise ex
src/containerapp/azext_containerapp/_client_factory.py:28:
There was a problem hiding this comment.
since debugging my take a while, and thie tests in this PR dont have this bug, if possible can this PR first be merged and then fixing this issue be a seperate PR @zhoxing-ms ?
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp create
az containerapp update
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.