[AKS] Add options for users to specify guardrails#6235
Conversation
|
Hi @NickKeller, |
|
AKS |
FumingZhang
left a comment
There was a problem hiding this comment.
Queued live test pipeline to verify the newly added test cases.
…cli-extensions into nikelle/aks-guardrails
|
@NickKeller Could you please resolve these CI issues? |
@zhoxing-ms These tests don't fail when I run |
|
@NickKeller Could you please try to re-record the test |
|
@zhoxing-ms I'm running it now, but I fail to see how that will help, considering it's a unit test, code of which I did not touch, is failing |
src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py:3760: AssertionError
This seems to be some logic issue from the unit testing itself + @FumingZhang help take a look~ |
|
Checked the error, should change |
|
Replaced by PR #6357 |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create|update -g <RGNAME> -n <CLUSTERNAME> --guardrails-level Warning --guardrails-version v1.0.0 --guardrails-excluded-ns ns1,ns2 --enable-addons azure-policyGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.