{AKS} feat: ga update for azure monitor for metrics addon (managed prometheus)#6241
Merged
Conversation
|
Hi @bragi92, |
Collaborator
|
AKS |
3 tasks
FumingZhang
approved these changes
May 10, 2023
yanzhudd
reviewed
May 10, 2023
Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
FumingZhang
reviewed
May 10, 2023
Member
There was a problem hiding this comment.
Queued live test pipeline to verify the change, test passed
yanzhudd
reviewed
May 10, 2023
yanzhudd
reviewed
May 10, 2023
yanzhudd
reviewed
May 10, 2023
…ults.py Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
…itorprofile.py Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
…er.py Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
yanzhudd
reviewed
May 10, 2023
…e.py Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
yanzhudd
reviewed
May 10, 2023
Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
yanzhudd
approved these changes
May 10, 2023
zhoxing-ms
approved these changes
May 10, 2023
Collaborator
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=53825&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks update -n kaveeshcli22 -g kaveeshcli --enable-azuremonitormetrics --enable-windows-recording-rulesaz aks create -n kaveeshcli22 -g kaveeshcli --location westeurope --enable-azuremonitormetrics --enable-windows-recording-rules --azure-monitor-workspace-resource-id "{full_id}" --grafana-resource-id "{full_id}"General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
Description
GA update for Azure Monitor Metrics. The changes for public preview where merged into the az cli extensions repo in the following PR: #5428
The GA update PR for the azure cli repo is here : Azure/azure-cli#26201
Testing Guide
az aks createandaz aks updateis being updated with the following parameters:type: bool
short-summary: Enable Azure Monitor Metrics Profile
type: string
short-summary: Resource ID of the Azure Monitor Workspace
type: string
short-summary: Comma-separated list of additional Kubernetes label keys that will be used in the resource' labels metric. By default the metric contains only name and namespace labels. To include additional labels provide a list of resource names in their plural form and Kubernetes label keys you would like to allow for them (e.g. '=namespaces=[k8s-label-1,k8s-label-n,...],pods=[app],...)'. A single '' can be provided per resource instead to allow any labels, but that has severe performance implications (e.g. '=pods=[]').
type: string
short-summary: Comma-separated list of additional Kubernetes label keys that will be used in the resource' labels metric. By default the metric contains only name and namespace labels. To include additional labels provide a list of resource names in their plural form and Kubernetes label keys you would like to allow for them (e.g.'=namespaces=[k8s-label-1,k8s-label-n,...],pods=[app],...)'. A single '' can be provided per resource instead to allow any labels, but that has severe performance implications (e.g. '=pods=[]').
type: string
short-summary: Resource ID of the Azure Managed Grafana Workspace
type: bool
short-summary: Enable Windows Recording Rules when enabling the Azure Monitor Metrics addon
type: bool
short-summary: Disable Azure Monitor Metrics Profile. This will delete all DCRA's associated with the cluster, any linked DCRs with the data stream = prometheus-stream and the recording rule groups created by the addon for this AKS cluster.
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.