{AKS} az aks update: don't always use the current kube-proxy config when updating cluster#6255
Merged
Merged
Conversation
|
Hi @tyler-lloyd, |
azure-client-tools-bot-prd
Bot
added this to the
May 2023 (2023-05-23) - For Build milestone
ghost
requested review from
ghost
assigned
Collaborator
|
AKS |
paulgmiller
reviewed
May 3, 2023
| # try to read the property value corresponding to the parameter from the `mc` object | ||
| if self.mc and self.mc.network_profile and self.mc.network_profile.kube_proxy_config is not None: | ||
| kube_proxy_config = self.mc.network_profile.kube_proxy_config | ||
| if self.decorator_mode == DecoratorMode.CREATE: |
There was a problem hiding this comment.
confused by this checking of create won't self.mc.network_profile alsways be empty in create?
Contributor
Author
There was a problem hiding this comment.
network_profile I do not think is empty on create. for example we using 10.244.0.0/16 as the default pod_cidr from the sdk
paulgmiller
reviewed
May 3, 2023
paulgmiller
left a comment
paulgmiller
left a comment
There was a problem hiding this comment.
confused abotu create but otherwise seems fine.
FumingZhang
reviewed
May 5, 2023
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
LGTM
Queued a live test pipeline to validate the change.
zhoxing-ms
approved these changes
May 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks updateGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.