Skip to content

{all services} Reorganized reference TOC by product or service (extensions)#6394

Merged
jsntcy merged 16 commits into
Azure:mainfrom
dbradish-microsoft:dbradish_refTOCupdate
Jun 29, 2023
Merged

{all services} Reorganized reference TOC by product or service (extensions)#6394
jsntcy merged 16 commits into
Azure:mainfrom
dbradish-microsoft:dbradish_refTOCupdate

Conversation

@dbradish-microsoft
Copy link
Copy Markdown
Contributor

@dbradish-microsoft dbradish-microsoft commented Jun 12, 2023 •
edited
Loading

The purpose of this PR is to refresh our reference TOC in corrected product or service groups. Sister PR is Azure/azure-cli#26657

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented Jun 12, 2023

Hi @dbradish-microsoft,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Jun 12, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@dbradish-microsoft dbradish-microsoft changed the title reorganized reference TOC by product or service TOC | reorganized reference TOC by product or service (extensions) Jun 12, 2023
@dbradish-microsoft dbradish-microsoft requested a review from dcaro June 12, 2023 20:43
@yonzhan yonzhan requested review from jsntcy and kairu-ms June 12, 2023 22:28
@dbradish-microsoft dbradish-microsoft marked this pull request as ready for review June 20, 2023 15:45
jsntcy
jsntcy reviewed Jun 21, 2023
View reviewed changes
Comment thread src/service_name.json
@dbradish-microsoft
Copy link
Copy Markdown
Contributor Author

dbradish-microsoft commented Jun 21, 2023

@dcaro , @jsntcy, I fixed build validation errors yesterday that are now popping up with time. If you could kindly review this PR and/or respond to conversations, I'd be grateful.

@dbradish-microsoft dbradish-microsoft mentioned this pull request Jun 21, 2023
Merged
dcaro
dcaro reviewed Jun 23, 2023
View reviewed changes
Copy link
Copy Markdown

@dcaro dcaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in different locations.

Comment thread src/service_name.json Outdated
Comment thread src/service_name.json Outdated
Comment thread src/service_name.json
Comment thread src/service_name.json Outdated
Comment thread src/service_name.json Outdated
Comment thread src/service_name.json
Comment thread src/service_name.json Outdated
Comment thread src/service_name.json Outdated
Comment thread src/service_name.json Outdated
Comment thread src/service_name.json Outdated
dbradish-microsoft and others added 9 commits June 23, 2023 12:49
@dbradish-microsoft @dcaro
Update src/service_name.json
2bff9bc 
Co-authored-by: Damien Caro <dcaro@microsoft.com>
@dbradish-microsoft @dcaro
Update src/service_name.json
ea779c0 
Co-authored-by: Damien Caro <dcaro@microsoft.com>
@dbradish-microsoft @dcaro
Update src/service_name.json
492c304 
Co-authored-by: Damien Caro <dcaro@microsoft.com>
@dbradish-microsoft @dcaro
Update src/service_name.json
eab5f38 
Co-authored-by: Damien Caro <dcaro@microsoft.com>
@dbradish-microsoft
Update service_name.json
fa66f3d
@dbradish-microsoft
Update service_name.json
8878750
@dbradish-microsoft
Update service_name.json
68a6cc6
@dbradish-microsoft
Update service_name.json
1d1b04e
@dbradish-microsoft
Merge branch 'main' into dbradish_refTOCupdate
5c6b67f
@dbradish-microsoft dbradish-microsoft changed the title TOC | reorganized reference TOC by product or service (extensions) {all services} Reorganized reference TOC by product or service (extensions) Jun 26, 2023
@dbradish-microsoft
Copy link
Copy Markdown
Contributor Author

dbradish-microsoft commented Jun 26, 2023

@jsntcy / @kairu-ms, @dcaro and I had a final review of this PR today. Can you please merge before more build conflicts pop up? Thank you.

#sign-off

@jsntcy
Copy link
Copy Markdown
Member

jsntcy commented Jun 27, 2023

@jsntcy / @kairu-ms, @dcaro and I had a final review of this PR today. Can you please merge before more build conflicts pop up? Thank you.

#sign-off

I still saw some comments from Damien were not resolved yet and also some suggestions were not committed yet.

@dbradish-microsoft @dcaro
Update src/service_name.json
fa20e60 
Co-authored-by: Damien Caro <dcaro@microsoft.com>
dbradish-microsoft and others added 2 commits June 27, 2023 09:40
@dbradish-microsoft @dcaro
Update src/service_name.json
b9dd4da 
Co-authored-by: Damien Caro <dcaro@microsoft.com>
@dbradish-microsoft
Update service_name.json
df742c0
@dbradish-microsoft
Copy link
Copy Markdown
Contributor Author

dbradish-microsoft commented Jun 27, 2023

@jsntcy, thank you for finding those missed suggestions. Does everything look okay now?

Sister PR: Azure/azure-cli#26657

@jsntcy
Copy link
Copy Markdown
Member

jsntcy commented Jun 28, 2023

LGTM
@dcaro, do you have any other comments? If no, I'll merge this PR.

@dbradish-microsoft
Copy link
Copy Markdown
Contributor Author

dbradish-microsoft commented Jun 28, 2023

@jsntcy, please merge in sync with Sister PR: Azure/azure-cli#26657. @dcaro and I are expecting a 2nd round of PRs with fewer edits once we see how the two Core and Extension files merged together.

@jsntcy jsntcy merged commit b8d4a3a into Azure:main Jun 29, 2023
dcaro
dcaro reviewed Jun 29, 2023
View reviewed changes
Comment thread src/service_name.json
dcaro
dcaro reviewed Jun 29, 2023
View reviewed changes
Comment thread src/service_name.json
@dcaro
Copy link
Copy Markdown

dcaro commented Jun 29, 2023

@jsntcy can we include the above changes in this release?

@jsntcy
Copy link
Copy Markdown
Member

jsntcy commented Jun 29, 2023

@jsntcy can we include the above changes in this release?

Yes, I created a PR for it, #6459, please help review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcaro dcaro dcaro left review comments

@jsntcy jsntcy jsntcy approved these changes

@kairu-ms kairu-ms Awaiting requested review from kairu-ms

Assignees

@jsntcy jsntcy

Labels

None yet

Projects

None yet

Milestone

June 2023 (2023-07-04)

Development

Successfully merging this pull request may close these issues.

4 participants

@dbradish-microsoft @yonzhan @jsntcy @dcaro