NetworkCloud 2023-05-01 API scenarios tests created for Networkcloud …

[priyamshet]

Related command

az networkcloud -h

Group
    az networkcloud : Manage Network Cloud resources.
        This command group is experimental and under development. Reference and support levels:
        https://aka.ms/CLI_refstatus
Subgroups:
    baremetalmachine     : Manage bare metal machine.
    cloudservicesnetwork : Manage cloud services network.
    cluster              : Manage cluster.
    clustermanager       : Manage cluster manager.
    defaultcninetwork    : Manage default CNI network.
    hybridakscluster     : Manage additional details of Hybrid AKS provisioned cluster.
    kubernetescluster    : Manage Kubernetes cluster.
    l2network            : Manage layer 2 (l2) network.
    l3network            : Manage layer 3 (l3) network.
    rack                 : Manage rack.
    racksku              : Manage rack SKU.
    storageappliance     : Manage storage appliance.
    trunkednetwork       : Manage trunked network.
    virtualmachine       : Manage virtual machine.
    volume               : Manage volume.

To search AI knowledge base for examples, use: az find "az networkcloud"

General Guidelines

• Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

NetworkCLoud AAZ PR : Azure/aaz#214

[azure-client-tools-bot-prd]

Hi @priyamshet,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

[yonzhan]

Thank you for your contribution! We will review the pull request and get back to you soon.

[priyamshet]

@kairu-ms Can we get request your review on this PR

[kairu-ms]

You can use to_serialized_data() function, which will serialize an AAZValue to python build-in type value.

Suggested change

	if list(args.ssh_dest_key_path):
	ssh_keys += CustomSshOptions.get_ssh_keys_from_path(
	list(args.ssh_dest_key_path)
	)
	if has_value(args.ssh_dest_key_path) and args.ssh_dest_key_path.to_serialized_data():
	ssh_keys += CustomSshOptions.get_ssh_keys_from_path(
	args.ssh_dest_key_path.to_serialized_data()
	)

[priyamshet]

if we update to to_serialized_data() , we encounter an error that list object does not have a to_serialized_data() , are we missing anything here?

[kairu-ms]

Can you share the code raise this error?
The AAZList has to_serialized_data function, but the python build-in list doesn't have to_serialized_data function. The output of to_serialized_data for AAZList is a python list.

[priyamshet]

This is what we see, please let us know if we are missing anything.

[kairu-ms]

If the values comes from to_serialized_data(), the key is string type by default.

[priyamshet]

As the calling function could not be updated to use to_serialized_data() due to an error (details in previous comment), leaving this as this. please let us know if we missed anything.

[priyamshet]

@kairu-ms We have addressed most of your feedback, Can we request your re-review on this please.

[azclibot]

[Release] Update index.json for extension [ networkcloud ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=67170&view=results