Skip to content

Add preview tag for new commands#6697

Closed
Juliehzl wants to merge 1 commit into
Azure:mainfrom
Juliehzl:user/zuh/add-preview
Closed

Add preview tag for new commands#6697
Juliehzl wants to merge 1 commit into
Azure:mainfrom
Juliehzl:user/zuh/add-preview

Conversation

@Juliehzl
Copy link
Copy Markdown
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented Aug 29, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1003 - CmdPropAdd containerapp env list-usages cmd containerapp env list-usages added property is_preview
⚠️ 1003 - CmdPropAdd containerapp list-usages cmd containerapp list-usages added property is_preview
⚠️ 1003 - CmdPropAdd containerapp show-custom-domain-verification-id cmd containerapp show-custom-domain-verification-id added property is_preview

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @Juliehzl,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @Juliehzl,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Aug 29, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@Juliehzl
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 6697 in repo Azure/azure-cli-extensions

Copy link
Copy Markdown
Contributor

@Seris370 Seris370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Juliehzl Juliehzl closed this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants