Skip to content

update VirtualMachines related helper msg#6881

Merged
zhoxing-ms merged 7 commits into
Azure:mainfrom
zqingqing1:qizhe/update-helper-msg
Nov 7, 2023
Merged

update VirtualMachines related helper msg#6881
zhoxing-ms merged 7 commits into
Azure:mainfrom
zqingqing1:qizhe/update-helper-msg

Conversation

@zqingqing1
Copy link
Copy Markdown
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create --vm-set-type "VirtualMachines"
az aks nodepool create --vm-set-type "VIrtualMachines"

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented Oct 19, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Oct 19, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Copy Markdown
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/aks-preview/HISTORY.rst
Comment thread src/aks-preview/azext_aks_preview/_help.py
Comment thread src/aks-preview/HISTORY.rst Outdated
@zhoxing-ms zhoxing-ms merged commit eb1ee6b into Azure:main Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants